Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Log task id on failure to get last report in time period. #1126

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Change: Log task id on failure to get last report in time period. #1126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6e941a
Change: Log task id on failure to get last report in time period.
a-h-abdelsalam Jul 26, 2024
7780024
Terminate script on failure to get last report.
a-h-abdelsalam Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/create-consolidated-report.gmp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#
# SPDX-License-Identifier: GPL-3.0-or-later

import sys
from argparse import ArgumentParser, Namespace, RawTextHelpFormatter
from datetime import date
from typing import List, Tuple
Expand Down Expand Up @@ -235,7 +236,12 @@
)
)
# should always be max 1 report
reports.append(reports_xml.xpath("report/@id")[0])
reports_id = reports_xml.xpath("report/@id")
if reports_id:
reports.append(reports_id[0])

Check warning on line 241 in scripts/create-consolidated-report.gmp.py

View check run for this annotation

Codecov / codecov/patch

scripts/create-consolidated-report.gmp.py#L239-L241 

Added lines #L239 - L241 were not covered by tests
else:
print(f"Failed to get report for task {task_id}", file=sys.stderr)
sys.exit(1)

Check warning on line 244 in scripts/create-consolidated-report.gmp.py

View check run for this annotation

Codecov / codecov/patch

scripts/create-consolidated-report.gmp.py#L243-L244 

Added lines #L243 - L244 were not covered by tests
return reports


Expand Down
Loading