Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressed lintian/shellcheck warnings #1471

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Addressed lintian/shellcheck warnings #1471

wants to merge 5 commits into from

Commits on Mar 29, 2021

  1. Replaced instances from non-standard "which" 

    with equivalent "command -v".
    Carlos A. Parra F committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    0fa23e7 View commit details
    Browse the repository at this point in the history

  2. Added missing warnings to 'cd' command in case of fail.

    Carlos A. Parra F committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    b1684bb View commit details
    Browse the repository at this point in the history

  3. Replaced legacy .. with equivalent $(..).

    Carlos A. Parra F committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    72b0a33 View commit details
    Browse the repository at this point in the history

  4. Satisfied all remaining shellcheck warnings: 

    * Replaced all remaining $.. with "$..".

* Replaced raw $? checks with better  ||, && and "if" checks.

* Packed chains of 'echo ".." >> $x; echo ".." >> $x' with better
  '{ echo ".."; echo ".." } >> $x'.

* exported locally unused variables (that are probably needed by other
  scripts).
    Carlos A. Parra F committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    fce467d View commit details
    Browse the repository at this point in the history

  5. Added changelog entry.

    Carlos A. Parra F committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    16a9e9a View commit details
    Browse the repository at this point in the history