Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use right command name when modifying report_configs #2152

Closed

Conversation

mattmundell
Copy link
Contributor

What

Fix some minor copy and paste errors in MODIFY_REPORT_CONFIG.

Why

Errors.

@mattmundell mattmundell requested a review from a team as a code owner March 12, 2024 15:14
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@mattmundell
Copy link
Contributor Author

mattmundell commented Mar 13, 2024

About the failed tests: am I missing permissions?

Test Analyze (c) is trying to run /usr/bin/docker pull /greenbone/gvmd-build:stable in step Create local container network. This gives an error because it's missing the registry before /greenbone. Maybe ${{ vars.IMAGE_REGISTRY }} is empty for me due to permissions? I can see that variable in gvmd > Settings > Secrets and Variables > Actions > Variables, but it is locked.

Compare with /pull/2125 opened by @a-h-abdelsalam where the same test runs fine. It is running /usr/bin/docker --config /home/runner/work/_temp/.docker_c6231b78-50e2-4758-90f3-308222a948a2 pull ghcr.io/greenbone/gvmd-build:stable which has the registry.

All my PRs are failing these tests.

@a-h-abdelsalam
Copy link
Contributor

@mattmundell Yes it looks like an unintended side-effect after some recent changes to the build-image workflow. Issue is already raised and should be fixed soon.

@timopollmeier
Copy link
Member

It looks like the current CI workflows require the branches to be created in the greenbone repo to have access to some variable, so I've created a copy of the branch and a new PR for this.

@mattmundell mattmundell deleted the modify-report-config-typos branch March 14, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants