Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: GMP doc: correct nvt and nvt_id in GET_OVERRIDES #2174

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

mattmundell
Copy link
Contributor

What

Correct the filter columns nvt and nvt_id for GET_OVERRIDES in the GMP doc.

Why

nvt is actually for an NVT name.

For example:

$ o m m '<get_overrides filter="nvt=1.3.6.1.4.1.25623.1.0.10049"/>'
<get_overrides_response status="200" status_text="OK">
  <filtered>0</filtered>

versus:

$ o m m '<get_overrides filter="nvt=Count.cgi"/>'
<get_overrides_response status="200" status_text="OK">
  <override id="1ecace58-88db-4c6c-82c2-81cd027ec7d2">...
  <filtered>1</filtered>

References

Similar to /pull/2171 for notes.

Examples above requires /pull/2173 else they hit an assert fail.

@mattmundell mattmundell requested a review from a team as a code owner April 21, 2024 14:56
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@bjoernricks bjoernricks force-pushed the gmp-doc-correct-nvt-overrides branch from 7e1be94 to d9ee35e Compare April 22, 2024 06:45
@bjoernricks bjoernricks enabled auto-merge (rebase) April 22, 2024 06:45
@bjoernricks bjoernricks merged commit 1edc11b into main Apr 22, 2024
9 checks passed
@bjoernricks bjoernricks deleted the gmp-doc-correct-nvt-overrides branch April 22, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants