Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: iterate with get_next in handle_get_notes and handle_get_overrides #2203

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Fix: iterate with get_next in handle_get_notes and handle_get_overrides #2203

merged 5 commits into from
Jun 14, 2024

Commits on Jun 14, 2024

  1. Move body of buffer_notes_xml to new function buffer_note_xml

    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    df92297 View commit details
    Browse the repository at this point in the history

  2. Remove const from get_next initializer arg 

    Some of the GET iterator initializers modify their get_data_t arg, so
this allows these initializers to be passed to get_next.

In particular this allows init_note_iterator_all to be passed to
get_next, for a fix to handle_get_notes.  Note that
init_note_iterator_all itself does not modify its get_data_t arg, but
init_note_iterator_all is passed to select_resource_iterator which
also accepts initializers that do modify their get_data_t args.

As a result drop the const from any initializer passed to get_next.
    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8e61336 View commit details
    Browse the repository at this point in the history

  3. Fix: iterate with get_next in handle_get_notes

    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e238c71 View commit details
    Browse the repository at this point in the history

  4. Move body of buffer_overrides_xml to new function buffer_override_xml

    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7751b12 View commit details
    Browse the repository at this point in the history

  5. Fix: iterate with get_next in handle_get_overrides

    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    26d9b4d View commit details
    Browse the repository at this point in the history