Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Remove own comparison operators, sort as semver #1000

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Apr 11, 2024

What

Remove the own comparison and use SemVer 2.0 comparison instead

We need to switch from alpha1 -> alpha.1 for the version sorting we want to achieve

Why

"Our" comparison system is not compatible with semver, as we do no compare lexical pre-versions correctly

We sorted -alpha10 > -alpha9, which looks correct, but is false in SemVer standard (longer string is "smaller" as a shorter string)

References

DEVOPS-1015

Checklist

  • Tests

Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (8d460a7) to head (11f4931).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   90.37%   90.35%   -0.03%     
==========================================
  Files         103      103              
  Lines        6963     6938      -25     
  Branches      986      973      -13     
==========================================
- Hits         6293     6269      -24     
  Misses        471      471              
+ Partials      199      198       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant