Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Use else for logger warning #875

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Change: Use else for logger warning #875

merged 1 commit into from
Sep 8, 2023

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Sep 8, 2023

What

Why

References

DEVOPS-733

@y0urself y0urself requested a review from a team as a code owner September 8, 2023 07:03
@y0urself y0urself added the make release To trigger GitHub release action. label Sep 8, 2023
@y0urself y0urself enabled auto-merge (squash) September 8, 2023 07:03
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #875 (a249be5) into main (34c947f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #875   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files          84       84           
  Lines        5603     5603           
  Branches      783      783           
=======================================
  Hits         5012     5012           
  Misses        421      421           
  Partials      170      170           
Files Changed Coverage Δ
pontos/version/commands/_java.py 83.13% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@y0urself y0urself merged commit c38b1e8 into main Sep 8, 2023
17 checks passed
@y0urself y0urself deleted the y0urself/else branch September 8, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants