Fix getting repo security and analysis #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the JSON schema doesn't mention the properties are optional it seems they are actually optional. The property `advanced_security` is missing in several of our responses and therefore we got a model error.
The status is missing in our model. Maybe it was added later on.
Conventional Commits Report
🚀 Conventional commits found. |
Make the error message more precise in what's wrong here actually.
bjoernricks
force-pushed
the
fix-getting-repo-security-and-analysis
branch
from
d850af1
to
c681169
Compare
Codecov Report
@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 84 84
Lines 5603 5604 +1
Branches 783 783
=======================================
+ Hits 5012 5013 +1
Misses 421 421
Partials 170 170
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
y0urself
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Don't crash when getting repositories when using a token.
Why
When using a token the security and analysis information is included in the response. Despite the JSON schema is not mentioning optional settings the
advanced_securityobject is not returned in our responses. To be able to still receive repository data the security and analysis settings are now marked as optional in the response models.References
Fixes https://jira.greenbone.net/browse/DEVOPS-822
Checklist