Fix various CodeQL alerts #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check_command_status function will now always explicitly return False unless the check succeeds while the non-None return from _ssh_authentication_input_loop has been removed.
Some unused local variables holding the return values from add_element calls are removed.
The class InvalidArgumentType now explicitly calls the superclass initializer, making it more explict that the message is set to None.
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 60 60
Lines 4445 4445
Branches 1060 1060
=======================================
Hits 4364 4364
Misses 67 67
Partials 14 14 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bjoernricks
previously approved these changes
Dec 19, 2023
bjoernricks
reviewed
Dec 19, 2023
Co-authored-by: Björn Ricks <[email protected]>
a-h-abdelsalam
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
False unless the check succeeds while the non-None return from
_ssh_authentication_input_loop has been removed.
calls are removed.
initializer, making it more explict that the message is set to None.
Why
This addresses various CodeQL alerts.
References
GEA-421
Checklist