Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Ignore script_tag vuldetect in overlong_description_lines #712

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2024

What

Adds 'script_tag(name:"vuldetect"' to exceptions of the plugin check_overlong_description_lines

Why

script_tag(name:"vuldetect", value:"Checks if a vulnerable version is present on the target host.\n");
is 102 characters and therefore triggers a warning but is a commonly used scrip_tag.

References

Checklist

  • Tests

@ghost ghost self-requested a review as a code owner June 10, 2024 08:47
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@mbrinkhoff mbrinkhoff enabled auto-merge (rebase) June 11, 2024 10:19
@mbrinkhoff mbrinkhoff added the make release To trigger GitHub release action label Jun 11, 2024
@mbrinkhoff mbrinkhoff force-pushed the overlong_description_exclusion branch from 9b35bdb to 64ffdd0 Compare June 11, 2024 10:19
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.15%. Comparing base (64c93fe) to head (9b35bdb).
Report is 1 commits behind head on main.

Current head 9b35bdb differs from pull request most recent head 64ffdd0

Please upload reports for the commit 64ffdd0 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files          84       84           
  Lines        2811     2811           
  Branches      595      595           
=======================================
  Hits         2225     2225           
  Misses        443      443           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbrinkhoff mbrinkhoff merged commit 7e8b502 into main Jun 11, 2024
10 checks passed
@mbrinkhoff mbrinkhoff deleted the overlong_description_exclusion branch June 11, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants