Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Various deprecated PCIDSS VT relevant clean-ups #717

Merged
1 commit merged into from
Jun 12, 2024
Merged

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Jun 12, 2024

What

  • Update exclusion pattern after moving some VTs
  • Remove various exclusion pattern which are no longer required / not valid anymore
  • Remove multiple TODOs which are no longer required / valid
  • Adjust tests accordingly

Maybe merge after #716 so that both are included in the next planned release

Why

  • Parts of the changes are required for greenbone/vulnerability-tests#11448 so that some files can be moved into a sub-folder (for consistency reasons)
  • Other parts are not required anymore as the checked / excluded VTs have been deprecated and thus the relevant code had been dropped. But it was missed to update / remove the exclusions from Troubadix
  • Parity PR for greenbone/vulnerability-tests#11970

References

None

Checklist

  • Tests

@cfi-gb cfi-gb added the make release To trigger GitHub release action label Jun 12, 2024
@cfi-gb cfi-gb requested a review from a team as a code owner June 12, 2024 10:11
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (61fb13d) to head (d0756bf).

Files Patch % Lines
troubadix/plugins/security_messages.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   79.28%   79.45%   +0.16%     
==========================================
  Files          85       85              
  Lines        2829     2823       -6     
  Branches      599      596       -3     
==========================================
  Hits         2243     2243              
+ Misses        443      440       -3     
+ Partials      143      140       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfi-gb cfi-gb force-pushed the pcidss_updates branch 2 times, most recently from ceac3a0 to 1c6212b Compare June 12, 2024 10:17
- Update exclusion pattern after moving some VTs
- Remove various exclusion pattern which are no longer required / not
  valid anymore
- Remove multiple TODOs which are no longer required / valid
- Adjust tests accordingly
@ghost ghost merged commit 62886e5 into main Jun 12, 2024
12 of 13 checks passed
@ghost ghost deleted the pcidss_updates branch June 12, 2024 12:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant