Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: update type hints #734

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Change: update type hints #734

merged 1 commit into from
Aug 28, 2024

Conversation

NiklasHargarter
Copy link
Contributor

What

Changes type hints used in core modules to Python 3.9 / 3.10. Change types that can be None to optional type. Removes unnecessary defaults of None.

Why

References

Checklist

  • Tests

Copy link

github-actions bot commented Aug 8, 2024

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@mbrinkhoff
Copy link
Member

Waiting for the internal team to confirm everybody uses Python 3.10 or later

@mbrinkhoff
Copy link
Member

Waiting for the internal team to confirm everybody uses Python 3.10 or later

I did not receive any mention that someone is still below python 3.10, so we will go ahead

@mbrinkhoff mbrinkhoff marked this pull request as ready for review August 14, 2024 09:15
@mbrinkhoff mbrinkhoff requested a review from a team as a code owner August 14, 2024 09:15
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.51%. Comparing base (ae2ad54) to head (4e3a577).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
troubadix/plugin.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #734   +/-   ##
=======================================
  Coverage   79.51%   79.51%           
=======================================
  Files          86       86           
  Lines        2910     2910           
  Branches      626      626           
=======================================
  Hits         2314     2314           
  Misses        450      450           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbrinkhoff mbrinkhoff merged commit 5ea203f into main Aug 28, 2024
12 of 13 checks passed
@mbrinkhoff mbrinkhoff deleted the update_type_hints branch August 28, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants