GP-44570 Fix start_date being required

This fixes an issue with start_date being defined as NOT NULL, which is not the case during async execution.
greenpeace-cee · Sep 26, 2024 · 428e70c · 428e70c
1 parent d924ee0
commit 428e70c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CRM/Sqltasks/DAO/SqltasksExecution.php b/CRM/Sqltasks/DAO/SqltasksExecution.php
@@ -6,7 +6,7 @@
  *
  * Generated from de.systopia.sqltasks/xml/schema/CRM/Sqltasks/SqltasksExecution.xml
  * DO NOT EDIT.  Generated by CRM_Core_CodeGen
- * (GenCodeChecksum:ee61d590625c7cb56c54bcbe5317b2ae)
+ * (GenCodeChecksum:fa4de32875d01a8b099e2d357fa8a670)
  */
 use CRM_Sqltasks_ExtensionUtil as E;
 
@@ -213,7 +213,7 @@ public static function &fields() {
           'type' => CRM_Utils_Type::T_DATE + CRM_Utils_Type::T_TIME,
           'title' => E::ts('Start Date'),
           'description' => E::ts('Start date of execution'),
-          'required' => TRUE,
+          'required' => FALSE,
           'usage' => [
             'import' => FALSE,
             'export' => FALSE,

diff --git a/sql/auto_install.sql b/sql/auto_install.sql
@@ -83,7 +83,7 @@ ENGINE=InnoDB;
 CREATE TABLE `civicrm_sqltasks_execution` (
   `id` int unsigned NOT NULL AUTO_INCREMENT COMMENT 'Unique SqltasksExecution ID',
   `sqltask_id` int unsigned COMMENT 'FK to SQL Task',
-  `start_date` datetime NOT NULL COMMENT 'Start date of execution',
+  `start_date` datetime NULL COMMENT 'Start date of execution',
   `end_date` datetime NULL COMMENT 'End date of execution',
   `runtime` int unsigned NULL COMMENT 'Task runtime in milliseconds',
   `input` longtext NULL COMMENT 'Task input',

diff --git a/xml/schema/CRM/Sqltasks/SqltasksExecution.xml b/xml/schema/CRM/Sqltasks/SqltasksExecution.xml
@@ -40,7 +40,7 @@
     <name>start_date</name>
     <title>Start Date</title>
     <type>datetime</type>
-    <required>true</required>
+    <required>false</required>
     <comment>Start date of execution</comment>
     <html>
       <type>Select Date</type>