GP-25238 Disable and standardize permission checks in API4 calls

greenpeace-cee · Feb 1, 2022 · bc3c8a5 · bc3c8a5
1 parent ef9c3c2
commit bc3c8a5
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/CRM/Mailutils/BAO/MailutilsThread.php b/CRM/Mailutils/BAO/MailutilsThread.php
@@ -107,7 +107,7 @@ public static function resolveThreadByMessage(array $params) {
 
     if (empty($thread_id)) {
       // no matching threads, create a new one
-      $thread_id = \Civi\Api4\MailutilsThread::create()
+      $thread_id = \Civi\Api4\MailutilsThread::create(FALSE)
         ->execute()
         ->first()['id'];
     }

diff --git a/Civi/Api4/Action/MailutilsMessage/Send.php b/Civi/Api4/Action/MailutilsMessage/Send.php
@@ -37,7 +37,7 @@ public function _run(Result $result) {
         ['MailutilsSetting AS mailutils_setting', 'INNER', NULL, ['mail_setting_id', '=', 'mailutils_setting.mail_setting_id']],
         ['Activity AS activity', 'LEFT', NULL, ['activity_id', '=', 'activity.id']],
       ])
-      ->addChain('mailutils_message_parties', \Civi\Api4\MailutilsMessageParty::get()
+      ->addChain('mailutils_message_parties', \Civi\Api4\MailutilsMessageParty::get(FALSE)
         ->addSelect('*', 'party_type_id:name')
         ->addWhere('mailutils_message_id', '=', '$id')
       )

diff --git a/Civi/Api4/Action/MailutilsThread/Get.php b/Civi/Api4/Action/MailutilsThread/Get.php
@@ -35,7 +35,7 @@ protected function getObjects(\Civi\Api4\Generic\Result $result) {
 
   private function getThreadIdsByContact($clause) {
     $threads = [];
-    $activities = \Civi\Api4\Activity::get()
+    $activities = \Civi\Api4\Activity::get(FALSE)
       ->setSelect([
         'mailutils_messages.mailutils_thread_id',
       ])

diff --git a/Civi/Mailutils/Processor.php b/Civi/Mailutils/Processor.php
@@ -19,9 +19,8 @@ public function __construct(\ezcMail $mail, int $activityId, int $mailSettingId)
       'id' => $mailSettingId,
     ]);
 
-    $mailutilsSettings = MailutilsSetting::get()
+    $mailutilsSettings = MailutilsSetting::get(FALSE)
       ->addWhere('mail_setting_id', '=', $mailSettingId)
-      ->setCheckPermissions(FALSE)
       ->execute()
       ->first();
     if (!empty($mailutilsSettings)) {

diff --git a/Civi/Mailutils/Processor/SupportCase.php b/Civi/Mailutils/Processor/SupportCase.php
@@ -20,11 +20,11 @@ public function __construct(int $activityId, int $supportCaseCategoryId) {
   public function process() {
     $activity = Activity::get(FALSE)
       ->addWhere('id', '=', $this->activityId)
-      ->addChain('contact', ActivityContact::get()
+      ->addChain('contact', ActivityContact::get(FALSE)
         ->addWhere('record_type_id', '=', 2)
         ->addWhere('activity_id', '=', '$id'),
         0)
-      ->addChain('message', MailutilsMessage::get()
+      ->addChain('message', MailutilsMessage::get(FALSE)
         ->addWhere('activity_id', '=', '$id'),
         0)
       ->execute()