Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP-44423 Use background queues for SEPA batching #2

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

mflandorfer
Copy link

No description provided.

This fixes an issue where CRM_Sepa_Logic_NextCollectionDate may
update next_sched_contribution_date for non-SEPA ContributionRecur
entities when they are modified.
This temporarily disables all mandate repairs. Some of them cause
data inconsistencies and performance issues on our environments.
@bjendres
Copy link

bjendres commented Jan 3, 2024

Very interesting, @pfigel and @mflandorfer! I'm currently implementing the runner for the "mark received' process, and I guess it would make sense to implement this in the same way.

Does this approach increase the minimum CiviCRM version?
Can you think of any reason not to put this into CiviSEPA master?

@mflandorfer mflandorfer requested review from pfigel and removed request for pfigel January 10, 2024 14:02
CRM/Sepa/Logic/Queue/Update.php Outdated Show resolved Hide resolved
CRM/Sepa/Logic/Queue/Close.php Outdated Show resolved Hide resolved
CRM/Sepa/Logic/Queue/Update.php Show resolved Hide resolved
CRM/Sepa/Logic/Queue/Update.php Outdated Show resolved Hide resolved
CRM/Sepa/Logic/Queue/Update.php Show resolved Hide resolved
CRM/Sepa/Logic/Queue/Update.php Outdated Show resolved Hide resolved
CRM/Sepa/Logic/Queue/Update.php Show resolved Hide resolved
@mflandorfer mflandorfer requested review from pfigel and removed request for pfigel February 6, 2024 14:36
@mflandorfer mflandorfer force-pushed the gp-44423-background-queues branch 2 times, most recently from 07391ec to 6cacbad Compare April 10, 2024 11:01
@mflandorfer mflandorfer requested a review from pfigel April 10, 2024 11:03
Copy link
Member

@pfigel pfigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a test run with Queue_Close with Sql instead of SqlParallel yesterday. I tried to close multiple groups at the same time (assuming that it would just queue them up and execute FIFO). It's hard to determine based on logs (due to the issue mentioned inline), but it looks like enqueuing a second close job somehow stopped one that was still being processed.

It's probably easiest to repeat the test after the flagged issues are fixed, as logs will be more useful then.

CRM/Sepa/Logic/Queue/Close.php Outdated Show resolved Hide resolved
CRM/Sepa/Logic/Queue/Close.php Outdated Show resolved Hide resolved
CRM/Sepa/Logic/Queue/Close.php Outdated Show resolved Hide resolved
@mflandorfer mflandorfer requested a review from pfigel April 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants