PLANET-4334 Allow a list of non-P4 urls not to have the ↗️ icon

[oekeur]

Summary

Adds the option to define a list of "Commonly used domains" under "Social" settings.
These domains should not get the external link icon and should always open in a new tab

As discussed in: greenpeace/planet4#174

Testing

• Under "Social" > "Commonly used external domains" add https://www.google.com (or another variation of the url)
• Test with content:

<!-- wp:paragraph -->
<p><a href="https://www.google.com">External link marked as commonly used</a><br>
<a href="https://www.google.com/android/find">Link with path marked as commonly used</a><br>
<a href="https://www.planet4.test/privacy-and-cookies/" data-type="page" data-id="232">Internal link</a> <br>
<a href="https://www.youtube.com/">External link NOT marked as commonly used</a></p>
<!-- /wp:paragraph -->

(or of course with any other content)

[oekeur]

Ping :) @lithrel @mleray

[lithrel]

Just a condition change on links target 👌

[lithrel]

I think we want external links to be the ones with target _blank

[oekeur]

External links were getting _blank, but only the commonly used external domains, that indeed doesn't seem right 😄
At least solved that -for now- in 874a3e4 (#1746).

I'm doubting though.. Should commonly used domains maybe NOT be opened in _blank? ie GPNL uses an external domain for petitions, it might be beneficial to open that one in the same tab. Kinda edge casey though, so maybe not important for the generic case?

[lithrel]

I'm doubting though.. Should commonly used domains maybe NOT be opened in _blank? ie GPNL uses an external domain for petitions, it might be beneficial to open that one in the same tab. Kinda edge casey though, so maybe not important for the generic case?

So I'm realizing now that your PR says

These ("Commonly used") domains should not get the external link icon and should always open in a new tab

but the ticket says

Help text: "Links for these domains will not open in a new tab and will hide the external link icon."
Adjust external link behaviour to remove external link icon and opening in a new tab for these domains.

There might be a misunderstanding then ? From what I understand, links on Commonly used domains should open in the same tab.

Your last change ends up in a double assignement for link.target, I think this should work

if (commonExternalDomains.includes(link.hostname)) {
  // Commonly used domains: force open in same tab, no external link icon
  link.target = '';
} else {
  // Other domains: follow post config, add external link icon
  link.target = link.target ?? ''; // follow post config
  link.classList.add('external-link'); // external link icon
}

[oekeur]

Hey @mleray ! Is this still relevant? 😅
I'll happily fix or close :)