-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-7527 Move blocks report into master theme #2303
base: main
Are you sure you want to change the base?
Conversation
/unhold a3f08390-c0ea-4d9d-acfc-fc87b67d8ad3
Test instance is ready 🚀🌑 venus | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.07.11 04:25:23 |
dc69e0d
to
b69f1a2
Compare
/unhold ee351bad-435b-4505-b140-69ef019468b2
b69f1a2
to
fdfa25c
Compare
/unhold 7e87a10b-7c89-47cc-86ee-3afdc6fc6ca4
fdfa25c
to
57bde5a
Compare
/unhold 67080fdd-b782-41e6-89df-7feebe034c60
57bde5a
to
bf4b7f2
Compare
/unhold d59731a1-229b-458c-be04-8aae142cdbbd
bf4b7f2
to
e220a29
Compare
/unhold 1a07c6bd-76d2-4981-8049-0d5f472f950c
e220a29
to
dfcb5cd
Compare
/unhold 0086272d-9270-4892-906e-2c307e333935
dfcb5cd
to
301889e
Compare
/unhold 4b5e5741-f302-4ebb-8b4a-f9392b93ea93
/unhold 5b7857bd-9965-4f3a-988d-70fcaee50bbd
/unhold 33820087-9daf-4a72-9ef3-ffff33c945f1
/unhold df9335af-abd5-4f23-b6a5-32e12fa2559a
/unhold 3620b3fa-f3ed-42f8-a5a6-9a1352519dc5
/unhold 97141e6d-32bf-4ece-b834-f46293b5224d
/unhold 43bbaa74-6394-41a4-9d10-a924d743758e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sagarsdeshmukh testing this locally we don't seem to have the report for planet4-block-templates
, was that intentional, because with the old implementation we had that report?
![Screenshot 2024-07-03 at 11 25 43](https://private-user-images.githubusercontent.com/38656549/345385124-1b253d5f-b0f2-47a5-9bf1-38790b7286c3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwMzY2MTcsIm5iZiI6MTcyMTAzNjMxNywicGF0aCI6Ii8zODY1NjU0OS8zNDUzODUxMjQtMWIyNTNkNWYtYjBmMi00N2E1LTliZjEtMzg3OTBiNzI4NmMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE1VDA5MzgzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI4MzViMzRjMDRjOWU2OGQ0OTlkNTUyMzZlMmE2Nzc2ZDFmNzFhMzY0NDMzNzNkNjM2NTI5ZTUzMGQzNDM5NjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iPJ7wXt5WsmL61bY2wplAtQ-WuZfge5w2HCUDanSQgg)
Good catch 👍 , It should show block templates as well. |
7fd8daa
to
13e9131
Compare
/unhold 6a31cf7e-35d1-49e8-a438-81a163449279
/unhold 670b2ee0-093d-450e-aa2b-821e6a5cf385
13e9131
to
3f10880
Compare
/unhold 49f7f2ad-ce21-4941-9b82-07a4692a7bdb
3f10880
to
f7bdb76
Compare
/unhold 60a598ad-23ca-44bb-b921-46527ced12c6
Hi @Osong-Michael , Could you please check now? |
Hey Sagar, just tested now. Still no ![]() ![]() |
Ref. https://jira.greenpeace.org/browse/PLANET-7527
The following folder name is changed during the migration to the master theme:
classes/search => src/BlockReportSearch
Testing:
De-activate the Blocks plugin, and check all blocks reports, It should work as expectedThe blocks report functionality should work as as expected