PLANET-7543 Add spinner to Greenpeace Media when searching for images #2314
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet-4
added a commit
to greenpeace/planet4-test-jupiter
that referenced
this pull request
Jun 25, 2024
/unhold 0d92a55e-f29b-4905-b93b-94a8c16a5099
Test instance is ready 🚀🌑 jupiter | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.07.01 11:53:53 |
mleray
force-pushed
the
greenpeace-media-search-loading
branch
from
0d7b9d3
to
34f6ee1
Compare
planet-4
added a commit
to greenpeace/planet4-test-jupiter
that referenced
this pull request
Jun 25, 2024
/unhold 287f5347-0508-4603-85c2-89d97d51fda5
mleray
force-pushed
the
greenpeace-media-search-loading
branch
from
34f6ee1
to
3a87c40
Compare
planet-4
added a commit
to greenpeace/planet4-test-jupiter
that referenced
this pull request
Jun 25, 2024
/unhold c3f32b09-ce9e-4565-9e12-2d580b88dfa7
mleray
force-pushed
the
greenpeace-media-search-loading
branch
from
3a87c40
to
ed3f44f
Compare
planet-4
added a commit
to greenpeace/planet4-test-jupiter
that referenced
this pull request
Jul 1, 2024
/unhold a0d8e5ff-54cb-4f75-b3b3-c18e66a6974b
mleray
force-pushed
the
greenpeace-media-search-loading
branch
from
ed3f44f
to
c8d3614
Compare
This is to indicate to users that their search is being processed
planet-4
added a commit
to greenpeace/planet4-test-jupiter
that referenced
this pull request
Jul 1, 2024
/unhold 94993a98-f6c3-4b79-b6e7-f6c9484d6eee
mleray
force-pushed
the
greenpeace-media-search-loading
branch
from
c8d3614
to
367bcba
Compare
planet-4
added a commit
to greenpeace/planet4-test-jupiter
that referenced
this pull request
Jul 1, 2024
/unhold 42e6e709-28b2-4ff6-92ed-a1503cc14f29
mleray
requested review from
sagarsdeshmukh
and removed request for
Osong-Michael
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-7543
Note: the spinner is different from the one in the ticket's screenshot, but this one is probably the newest WP one and it has been approved by the design team.
Testing
You can go to Greenpeace Media either on local or on the jupiter instance. When you search for a term then the spinner should now appear next to the search input on mobile, and next to the Search button in bigger screens.