PLANET-7647 Enforce consistency on default favicon #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Jan 21, 2025
/unhold db2c7bb6-ff3e-4724-bce8-a489944395ff
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Jan 21, 2025
/unhold dd69ef98-2642-443c-8125-ee64fb0a81a9
We remove the option to customize it in the site identity settings, and we need to run a migration to remove existing values
mleray
force-pushed
the
default-favicon
branch
from
98390d7 to
0e29a20
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Jan 21, 2025
/unhold e137cd9c-7d5a-457a-94bf-e3ae73c7fe66
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Jan 21, 2025
/unhold 4fd16a74-3aac-4022-b8b9-f491e69bbdb9
planet-4
added a commit
to greenpeace/planet4-test-tavros
that referenced
this pull request
Jan 21, 2025
/unhold 987691d2-91db-4c08-a6e0-2aca9c68f5c1
Test instance is ready 🚀🌑 tavros | admin | blocks report | CircleCI | composer-local.json ⌚ 2025.01.21 11:26:41 |
mleray
requested review from
comzeradd,
a team and
Osong-Michael
and removed request for
a team
There was a problem hiding this comment.
Hey @mleray after the migration, we loose the favicon for the page when on the admin dashboard and not the site itself, is this the expected behaviour?
Test Instance
Local Instance
PS: Does not seem like a big deal since only editors use this.
@Osong-Michael I do not see this on the instance 🤔 The icon is updated in the admin interface too 
Edit: I do see the issue on local, but only in certain admin pages, not all of them... weird! |
Osong-Michael
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-7647
We remove the option to customize it in the site identity settings, and we need to run a migration to remove existing values
Testing
1. Setting removal
If you go to
Appearance > Customize > Site Identityyou should no longer be able to change the site icon.Before the removal you would see this:
2. Migration script
You can run it on local with
npx wp-env run cli wp p4-run-activatorBefore the migration, we had a custom site icon:
After the migration, you should now see the default site icon: