This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Make db a parameter of serialize() #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihong0618
reviewed
Aug 2, 2023
| @@ -546,20 +546,20 @@ def in_(self, container: Union["Expr", List[Any]]) -> "InExpr": | |||
| from psycopg2.extensions import adapt # type: ignore | |||
|
|
|||
|
|
|||
| def _serialize(value: Any) -> str: | |||
| def _serialize_to_expr(obj: Any, db: Optional[Database] = None) -> str: | |||
There was a problem hiding this comment.
why not name it to serialize_to_expr? since others will import it
There was a problem hiding this comment.
Just want to prevent it from being imported by the user.
greenplumpython/type.py
Outdated
Comment on lines
60
to
85
| # def _bind( | ||
| # self, | ||
| # dataframe: Optional["DataFrame"] = None, | ||
| # db: Optional[Database] = None, | ||
| # column_name: str = None, | ||
| # ) -> "Expr": | ||
| # # noqa D102 | ||
| # self._db = db | ||
| # if isinstance(self._obj, Expr): | ||
| # self._obj = self._obj._bind( | ||
| # dataframe=dataframe, | ||
| # db=db, | ||
| # ) | ||
| # return self | ||
| # | ||
| # def apply( | ||
| # self, expand: bool = False, column_name: Optional[str] = None, row_id: Optional[str] = None | ||
| # ) -> "DataFrame": | ||
| # # noqa D102 | ||
| # from greenplumpython.dataframe import DataFrame | ||
|
|
||
| # if expand and column_name is None: | ||
| # column_name = "func_" + uuid4().hex | ||
| # return DataFrame( | ||
| # f""" | ||
| # SELECT {(row_id + ',') if row_id is not None else ''} |
ruxuez
reviewed
Aug 3, 2023
yihong0618
approved these changes
Aug 3, 2023
ruxuez
approved these changes
Aug 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
dbis an attribute of classExprand its valuecannot be decided when init a new object. As a result, when the
Expris serialized, we need to explicitly bind it to a db tocreate functions or types. However, in some cases we forgot to
do that, which lead to errros.
To avoid forgotting this, this patch moves db to a parameter of
serialize()and pass db to it each time we call it.This patch fixes the following bugs in
serialize():type.
*is not serialized correctly in column filedswhen expanding a composite type result.
count(*)returns wrong result when dataframe containsNone.