Fix missing goto and clarify some CLI documentation
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes some rough edges on Yubico#323.
Specifically:
gotostatement that letsyhunwrapcontinue to execute after encountering an error conditions/wrap/unwrapin the CLI documentation, since that's what this new binary doesFeel free to disregard point 3 if it seems extraneous. However, anecdotally, I spent a fair bit of time trying to figure out why my decrypt operations were failing before realizing that the input formats for the files are different. Perhaps this is obvious if you regularly work with
yubihsm-shell, but it wasn't to me (and in general, I find the lack of documentation on file formats inyubihsm-shellto be frustrating so it's possible I'm missing something).