Allow manually displayPreferenceDialog #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the use case of this? Also the |
zhanghai
reviewed
Nov 9, 2017
| if (fragment != null) { | ||
| fragment.setArguments(b); | ||
| if (fragment instanceof DialogFragment) { | ||
| fragment.setTargetFragment(this, 0); |
There was a problem hiding this comment.
If this is going to be merged, can you move fragment.setTargetFragment(this, 0) out of the instanceof DialogFragment if so that all fragments get a reference to the preference fragment? See #87 (comment) .
|
Merged (added some annotations to the method and removed some non-null checks). Will be released in v27.0.1.1. |
|
Yay. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.