Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action to replace file content #121

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

andersonaguiaralves
Copy link

Fix issue #65

Hey fellows, my test it's not 100%, can you guys help me with this?

Line 18 it's reading the file before the changes are made and it returns "lorem-ipsum", I need this to return "loren.ipsun" (because of my mutations in line 37), and then I'll be able to change line 22 to return data == pattern to a perfect test.

Thank you.

src/options-schema.js Outdated Show resolved Hide resolved
@sibiraj-s
Copy link
Collaborator

Any thoughts regarding the issue mentioned here #65 (comment)?

@andersonaguiaralves
Copy link
Author

Any thoughts regarding the issue mentioned here #65 (comment)?

I really don't know .

Let me explain to you how I use replaceInFile:

Microfrontend is knocking on my door. I'm running a Magento 2 application, and after using filemanager-webpack-plugin to move a React Application files to a Magento 2 module, now I'm able to replace some files with some important terms (because Magento 2 uses PHP) to make it run.

That's very powerful because now I'm able to run react components in a Magento Application.

Well, that's the way this implementation was useful to me. I guess other developers can use their imagination to use Replace In File as they can or even make ReplaceInFile more and more complete, with other good options.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants