Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add w/o grouping run in golden test #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add w/o grouping run in golden test #5

wants to merge 5 commits into from

Conversation

lizard-boy
Copy link
Collaborator

Original PR: uber-go/nilaway#253

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Overall, the PR introduces a matrix strategy in the golden test workflow to support both grouped and ungrouped error outputs, updating both tests and main functionality accordingly.

  • Modified file: /.github/workflows/golden-test.yml to add a matrix with entries for grouping and non-grouping runs.
  • Updated file: tools/cmd/golden-test/main_test.go to hardcode and validate the grouping flag behavior.
  • Altered file: tools/cmd/golden-test/main.go to accept and pass the grouping flag dynamically.
  • Potential issue: Standard log functions are used for error logging instead of the custom logger.error module.

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants