Create block to display external IP address information

[cfsmp3]

Display our external IP address and information about it (country, region, location, ISP, etc).

• To test

[[block]]
block = "external_ip"
format = "{address} {country} {country_code} {region} {region_name} {city} {zip} {latitude} {longitude} {timezone} {isp} {org} {autonomous_system} {country_flag}"

• Possibly some non-rustic code there, feel free to school me.
• serde_derive and service don't get really well (both export Serialize). Used an alias for one of them. Proper solution welcome.
• Using a free API to get all the info. Only limitation this API has that we might sort of care about is that it's http, not https (on the free tier).
• Includes country flag representation but it requires a font that includes them. See blocks doc for details.
  -Tested with IPv4 only.

[MaxVerevkin]

Using a free API to get all the info. Only limitation this API has that we might sort of care about is that it's http, not https (on the free tier).

This should probably be mentioned in the docs.

[cfsmp3]

Using a free API to get all the info. Only limitation this API has that we might sort of care about is that it's http, not https (on the free tier).

This should probably be mentioned in the docs.

Added.

[MaxVerevkin]

This addition doesn't look NetworkManager-specific, so perhaps it could be added to net block instead? And just to point out, this functionality can be accomplished with custom block:

# County flag
[[block]]
block = "custom"
command = """curl -s http://ip-api.com/json | jq -r '.countryCode' | python -c 'print("".join(map(lambda x: chr(ord(x)+127397),input())))'"""
interval = 60

# County code
[[block]]
block = "custom"
command = """curl -s http://ip-api.com/json | jq -r '.countryCode'"""
interval = 60

# Address
[[block]]
block = "custom"
command = """curl -s http://ip-api.com/json | jq -r '.query'"""
interval = 60

[cfsmp3]

This addition doesn't look NetworkManager-specific, so perhaps it could be added to net block instead?

The net block doesn't have the very useful DBus listener stuff to detect changes as they happen. I actually started adding it there but it was clearly going in the wrong direction.

I could create a separate block just for this (which would be a copy of this one minus part of the preexisting stuff), but I'm not sure that's also a good idea.

And just to point out, this functionality can be accomplished with custom block:

First - I personally refuse to be spawning processing every X seconds to populate the bar, if I wanted that I would be using the old bar which has a trillion of those scripts :-) Second, with a custom block you won't be able to immediately react to changes anyway.

[cfsmp3]

I've built my own block with blackjack and hookers.

[MaxVerevkin]

Only limitation this API has that we might sort of care about is that it's http, not https (on the free tier).

Why not use https://ipapi.co/json/ which is already used by weather block?

[cfsmp3]

Why not use https://ipapi.co/json/ which is already used by weather block?

Because I wasn't aware of it :-)

[cfsmp3]

@MaxVerevkin I've switched to that one. It's missing the ISP though, which is somewhat valuable, but I prefer having https over that specific field.

[MaxVerevkin]

Also I think NetworkManager thread should be optional (perhaps on by default?) because this block can be useful for non NetworkManager users too.

[cfsmp3]

Also I think NetworkManager thread should be optional (perhaps on by default?) because this block can be useful for non NetworkManager users too.

I've added that.
However, I do have a problem with the periodic updates: They aren't happening anywhere close to the configured interval. Can you take a look at the code, where am I going wrong? It seems quite straightforward, but with this config:

[[block]]
block = "external_ip"
format = "{ip} {country_flag}"
refresh_interval_success = 60

I'd expect one poll every minute, and that's not happening (I'm monitoring traffic with wireshark).

[MaxVerevkin]

It appears that postal can be null. Besides that, I don't know what could be wrong with your code - the update function runs correctly every N seconds. I don't have experience with linux network monitoring, but it seems to work just fine.

[cfsmp3]

• the update function runs correctly every N seconds.

How do you know for sure?

[MaxVerevkin]

How do you know for sure?

I've put an eprintln! in there :)

[cfsmp3]

How do you know for sure?

I've put an eprintln! in there :)

OK, can't argue with that :-)

[MaxVerevkin]

There are clippy warnings, but apart from that, looks good to me.

[cfsmp3]

There are clippy warnings, but apart from that, looks good to me.

Fixed.

[MaxVerevkin]

Thanks! By the way, if you want to tinker with some async rust code, you can port this block overt to async version which will hopefully be merged at some point (#1369) :)