Reduce amount of blocking in blocks #2093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxVerevkin
reviewed
Nov 9, 2024
src/util.rs
Outdated
| @@ -7,6 +7,10 @@ use tokio::process::Command; | |||
|
|
|||
| use crate::errors::*; | |||
|
|
|||
| pub async fn file_exists(path: impl AsRef<Path>) -> bool { | |||
| tokio::fs::metadata(path).await.is_ok() | |||
There was a problem hiding this comment.
Is there a reason to choose this over tokio::fs::try_exists? And do we even need a separate util function?
There was a problem hiding this comment.
This matches the implementation that it was replacing exists: https://doc.rust-lang.org/nightly/src/std/path.rs.html#3030-3032
Perhaps all of the exists should be try_exists (either async or sync, spending on the context though)?
Replaced `exists` with `try_exists`
bim9262
force-pushed
the
rdx_blocking
branch
from
0fa560f to
08e2947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.