DC Branch Support #148
Merged
DC Branch Support #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bknueven I just blindly took any code that dealt with branch elements and included dc_branch elements as well. I don't know if that was always the right thing to do, and as a result this PR is marked as WIP. Feel free to take off the WIP status after you've reviewed it if you feel OK about where I added DC support. Most of the changes boiled down to looping over two sets of elements instead of just one. Wherever there used to be for loops over branch elements, I leaned toward including both kinds of branches in a single loop rather than copying the code into a second loop. Also, I added a couple of TODO comments I hope you'll notice and resolve. |
Co-authored-by: bknueven <[email protected]>
bknueven
reviewed
Jun 13, 2022
bknueven
reviewed
Jun 13, 2022
bknueven
reviewed
Jun 13, 2022
Co-authored-by: bknueven <[email protected]>
Co-authored-by: bknueven <[email protected]>
Co-authored-by: bknueven <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we just added support for dc_branch elements in the Egret GMLC parser, we want to be sure Prescient includes DC branches in its logic and reporting.