Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RTS-GMLC as input format #95

Merged

Conversation

darrylmelander
Copy link
Collaborator

@darrylmelander darrylmelander commented May 11, 2021

Depends on Egret PR grid-parity-exchange/Egret#209

@bknueven bknueven linked an issue May 12, 2021 that may be closed by this pull request
Copy link
Collaborator

@bknueven bknueven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to test this, but the code itself looks good.

prescient/engine/forecast_helper.py Show resolved Hide resolved
Can be either "dat" (the default) or "rts-gmlc".  The option causes the
corresponding data_provider to be used.
* If use_next_day_in_ruc, none of the values are inferred (i.e., estimated based on the previous values)
* Otherwise, all values after the first 24 hours are inferred.
  - For wind generators, the inferred values are all repeats of the final value of the non-inferred data
  - For all other data, the inferred values are copies of the first 24 hours of data
* Forecasts that start at midnight are no longer treated as a special case.
* For DAT files, all non-inferred values come from the DAT file for the day of the time step. This
  means a DAT file with more than 24 hours of data will never use the extra hours of data.
…f actuals.

If the new batch is smaller than previous batches, it wasn't discarding enough of the old value.
@darrylmelander darrylmelander merged commit 948ae98 into grid-parity-exchange:main Jun 4, 2021
@darrylmelander darrylmelander deleted the rts-gmlc-parser branch June 4, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a non-dat DataProvider
2 participants