seperate the two types of HVDC station #684
Open
+68
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thangqp
reviewed
Feb 17, 2025
| HVDC_LINE_VSC: 'HVDC_LINE_VSC', | ||
| } as const; | ||
|
|
||
| export const EQUIPMENT_INDEXED_TYPE: Record< |
There was a problem hiding this comment.
I don't see the usage of this object, it should replace the usage of EQUIPMENT_TYPE some where in commons-ui?
There was a problem hiding this comment.
There was a problem hiding this comment.
The second usage is at : https://github.com/gridsuite/commons-ui/blob/main/src/hooks/useModificationLabelComputer.tsx#L73
But I think there a mistake, should be EquipmentType.HVDC_LINE instead of EQUIPMENT_TYPE.HVDC_LINE which is an object (never compare two objects in JS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.