Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway panel in pods supervision #468

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Add gateway panel in pods supervision #468

merged 2 commits into from
Dec 26, 2024

Conversation

YenguiSeddik
Copy link
Contributor

No description provided.

@antoinebhs
Copy link
Contributor

For this to work, I had to add the gateway IP in prometheus.yaml, I think we should add it?

@antoinebhs
Copy link
Contributor

I'm not sure what's the actual difference between active vs connections, can you detail this part?
If I understand the metrics we're monitoring the number of synchronous processing (this does not include for example asynchronous processing with queues), is it correct?

Signed-off-by: Seddik Yengui <[email protected]>
@antoinebhs
Copy link
Contributor

For this to work, I had to add the gateway IP in prometheus.yaml, I think we should add it?

Still not added?

@@ -834,7 +834,7 @@
},
"editorMode": "code",
"exemplar": false,
"expr": "sum(tomcat_threads_current_threads) by (pod)",
"expr": "sum(tomcat_threads_current_threads) by (pod) or or sum(reactor_netty_http_server_connections) by (pod)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"expr": "sum(tomcat_threads_current_threads) by (pod) or or sum(reactor_netty_http_server_connections) by (pod)",
"expr": "sum(tomcat_threads_current_threads) by (pod) or sum(reactor_netty_http_server_connections) by (pod)",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -1126,13 +1126,213 @@
],
"type": "table"
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these panels for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep only changes above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Seddik Yengui <[email protected]>
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Tests OK

@YenguiSeddik YenguiSeddik merged commit 1386823 into main Dec 26, 2024
2 checks passed
@YenguiSeddik YenguiSeddik deleted the add_gateway_panel branch December 26, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants