Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sections management to shunt compensators creation #355

Merged
merged 7 commits into from
Oct 30, 2023

Conversation

Meklo
Copy link
Contributor

@Meklo Meklo commented Oct 24, 2023

No description provided.

@Schema(description = "Maximal susceptance available")
private Double maxSusceptance;

@JsonProperty("maxQAtNominalV")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need for this @JsonProperty("maxQAtNominalV")
you can remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Meklo Meklo requested a review from achour94 October 27, 2023 07:45
@Meklo Meklo requested a review from ayolab October 27, 2023 09:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Meklo Meklo merged commit f33829c into main Oct 30, 2023
4 checks passed
@Meklo Meklo deleted the add_sections_to_shunt_compensators branch October 30, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants