Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collection impact #356

Merged
merged 46 commits into from
Mar 5, 2024
Merged

Add collection impact #356

merged 46 commits into from
Mar 5, 2024

Conversation

sBouzols
Copy link
Contributor

No description provided.

@sBouzols
feat(): Add collection impact
54b0b69 
Signed-off-by: sBouzols <[email protected]>
@sBouzols
Merge branch 'main' into feat_add_collection_impact_2
78094aa
@sBouzols
feat(): Replace collection factor by collection threshold to avoid ge…
ae9d0a7 
…tting network nb elements for comparison and then all those elements (sub optimal).

Compute collection impacts just befor the flush instead of as the listener run.
Ignore DELETION impacts from this computation
test(): update TUs fixing collection threshold to 5 to avoid needs of big networks

Signed-off-by: sBouzols <[email protected]>
@sBouzols
docs(): add author infos
ca791c3 
Signed-off-by: sBouzols <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

98.6% 98.6% Coverage
0.0% 0.0% Duplication

@sBouzols sBouzols changed the title [WIP] Add collection impact Add collection impact Feb 8, 2024
@sBouzols sBouzols force-pushed the feat_add_collection_impact_2 branch from df90bee to e1fa819 Compare February 9, 2024 16:11
@sBouzols sBouzols requested a review from SlimaneAmar February 9, 2024 17:19
@sBouzols
fix() from review
74cd686 
Signed-off-by: sBouzols <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

SlimaneAmar
SlimaneAmar approved these changes Mar 5, 2024
View reviewed changes
src/test/resources/application-default.yml Outdated Show resolved Hide resolved
ne0ds
ne0ds approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@ne0ds ne0ds left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Ok, untested.

@sBouzols sBouzols merged commit ac7c3ad into main Mar 5, 2024
3 checks passed
@sBouzols sBouzols deleted the feat_add_collection_impact_2 branch March 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlimaneAmar SlimaneAmar SlimaneAmar approved these changes

@ne0ds ne0ds ne0ds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sBouzols @ne0ds @SlimaneAmar