Separate computation logs from modification logs #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
…odification_logs' into separate_computation_logs_from_modification_logs
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
changed the title
SlimaneAmar
reviewed
Nov 20, 2023
| @@ -88,7 +88,8 @@ public UUID runLoadFlow(UUID studyUuid, UUID nodeUuid, LoadFlowParametersInfos l | |||
| .fromPath(DELIMITER + LOADFLOW_API_VERSION + "/networks/{networkUuid}/run-and-save") | |||
| .queryParam(QUERY_PARAM_RECEIVER, receiver) | |||
| .queryParam("reportUuid", reportUuid.toString()) | |||
| .queryParam("reporterId", nodeUuid.toString()); | |||
| .queryParam("reporterId", nodeUuid.toString()) | |||
| .queryParam("reportType", StudyService.ReportType.LOADFLOW.toString()); | |||
There was a problem hiding this comment.
Add a constant for query params ?
| LOAD_FLOW, SECURITY_ANALYSIS, SENSITIVITY_ANALYSIS | ||
| } | ||
|
|
||
| public enum TaskKeyFilterMatchingType { |
There was a problem hiding this comment.
ReportNameMatchingType ?
| } | ||
|
|
||
| @Transactional(readOnly = true) | ||
| public List<ReporterModel> getParentNodesReport(UUID nodeUuid, boolean nodeOnlyReport, Set<String> severityLevels) { | ||
| public List<ReporterModel> getParentNodesReport(UUID nodeUuid, boolean nodeOnlyReport, ReportType reportType, Set<String> severityLevels) { | ||
| String taskKeyFilter; |
There was a problem hiding this comment.
Too complex !
Add a method getFiltersParamaters ?
| @@ -54,6 +54,7 @@ private StudyConstants() { | |||
| public static final String QUERY_PARAM_REPORT_SEVERITY_LEVEL = "severityLevels"; | |||
| public static final String QUERY_PARAM_REPORT_WITH_ELEMENTS = "withElements"; | |||
| public static final String QUERY_PARAM_REPORT_TASKKEY_FILTER = "taskKeyFilter"; | |||
| public static final String QUERY_PARAM_REPORT_TASKKEY_FILTER_MATCHING_TYPE = "taskKeyFilterMatchingType"; | |||
There was a problem hiding this comment.
Same remark as report server
Rename the notion REPORT_TASKKEY_FILTER by REPORT_NAME_FILTER
Signed-off-by: David BRAQUART <[email protected]>
SlimaneAmar
approved these changes
Nov 22, 2023
|
Kudos, SonarCloud Quality Gate passed! |
dbraquart
deleted the
separate_computation_logs_from_modification_logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.