feat: include molecular profile segment data in molecular profile response #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I remember, you did the right thing for creating the test cache pkl file. I think when I made these updates, I created a pkl from my local database since the changes weren't actually deployed yet and the ID I used in the tests would've been one from my local database and it was possibly a molecular profile that I created manually. You did the right thing by updating the ID and tests to something that matches a molecular profile in production. |
susannasiebert
force-pushed
the
issue-143
branch
from
fdf6021 to
5095471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #143 . This is needed for this hackathon issue.
@susannasiebert I can't remember how the
test_cache.pklis populated for the tests. I rancivicpy update --hardand used this as my cache. The molecular profile tests had6353as an ID. I tried using the graphiql api and looked at https://civicdb.org/molecular-profiles/6353/summary , but the molecular profile does not exist. 3 of the tests are failing (on both my cache with changes from my branch and the cache from themasterbranch). Depending on how thetest_cache.pklis populated, I can update in a separate issue.