remove "black magic" workaround for older setuptools #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newest setuptools doesn't provide "finders" attribute, so setup.py cannot execute. If you don't like the removal, maybe some conditions or a try/except block will workaround the removal of the workaround for older setuptools versions. See <kmike/nltk@f34b390> for source of fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newest setuptools doesn't provide "finders" attribute, so setup.py cannot execute.
See kmike/nltk@f34b390 for source of fix.
(If you don't agree with the removal of the lines, maybe some conditions or a try/except block will workaround the removal of the workaround for older setuptools versions.)