Added maxoptcycles configuration to .censorc. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 75b4939 into ed326c9 - view on LGTM.com new alerts:
|
- Keeping old behaviour as "maxoptcycles: old" - Adding new automatic setup (50 + 3*nat) as "maxoptcycles: automatic" - Allows manual setting of maximum optimization cyles for part 2. Signed-off-by: MtoLStoN <[email protected]>
fabothch
reviewed
Jun 29, 2022
| @@ -1674,6 +1676,7 @@ def __init__(self, **kwargs): | |||
| "crestcheck": ["on", "off"], | |||
| "maxthreads": ["number of threads e.g. 2"], | |||
| "omp": ["number cores per thread e.g. 4"], | |||
| "maxoptcycles": ["old", "automatic", "number of maximum cycles e.g. 200"], | |||
There was a problem hiding this comment.
Since the values can be string or int you should add a check in the function check_logic
There was a problem hiding this comment.
Should be added here:
CENSO/censo_qm/inputhandling.py
Line 2759 in ed326c9
There was a problem hiding this comment.
Something like this:
if self.maxoptcycles not in ['old','automatic']
try:
int(self.maxoptcycles)
except ValueError:
error_logical = True
- add printout warning
fabothch
reviewed
Jun 29, 2022
| else: | ||
| stopcycle = 200 | ||
| stopcycle = int(config.maxoptcycles) |
There was a problem hiding this comment.
can be dangerous if you do not check that config.maxoptycle can be converted to int
Signed-off-by: MtoLStoN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MtoLStoN [email protected]