Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continuous integration #31

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Fix continuous integration #31

merged 11 commits into from
Jul 31, 2024

Conversation

marcelmbn
Copy link
Member

  • update GH workflow to more recent Python version
  • remove redundant environment variable sourcing

marcelmbn added 11 commits July 31, 2024 17:35
@marcelmbn
update GH workflow to more recent Python version and Intel env vars
8d022ab 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
fix intel compiler version and increase gcc version for macOS
32177d9 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
remove unnecessary brew install and take appropriate gfortran version
8b4c86f 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
check gfortran version
93a8245 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
add brew install command back again
cc1b088 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
check only for present gfortran versions
6e0297f 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
correct alias for pre-installed gfortran and gcc
104205a 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
use symbolic link instead of alias
66b5474 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
install openblas for lapack
016c7a4 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
use openBLAS instead of Accelerate
9a0798c 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
add some more compiler flags to find openblas
ddc1fdd 
Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn
Copy link
Member Author

marcelmbn commented Jul 31, 2024 •
edited
Loading

All CI checks should be passing now. Unfortunately, I had to use openblas instead of the native Accelerate platform to make it work with meson. If anybody has an idea why cmake can find Accelerate but meson not, they're very welcome.
I decided to use the pre-installed gfortran and gcc according to https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md and link them instead of re-installing it.
Fixed #30 with this.

@marcelmbn marcelmbn self-assigned this Jul 31, 2024
@marcelmbn marcelmbn added the bug Something isn't working label Jul 31, 2024
@marcelmbn
Copy link
Member Author

Additional comment: gcc-11 will be removed from all macOS images, which is why I've decided to test with gcc-12

awvwgk
awvwgk approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Looks good to me.

@awvwgk awvwgk linked an issue Jul 31, 2024 that may be closed by this pull request
Failing macOS-latest and ubuntu-latest CI runs #30
Closed
@marcelmbn marcelmbn merged commit 92b37fb into grimme-lab:main Jul 31, 2024
7 checks passed
@marcelmbn marcelmbn deleted the fix/CI branch July 31, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

@lukaswittmann lukaswittmann Awaiting requested review from lukaswittmann

Assignees

@marcelmbn marcelmbn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing macOS-latest and ubuntu-latest CI runs
2 participants
@marcelmbn @awvwgk