Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean flag skip_router to Context #69

Closed
wants to merge 3 commits into from

Conversation

cyangle
Copy link
Contributor

@cyangle cyangle commented Aug 16, 2024

Description of the Change

Allow skipping http_handler and websocket_handler by setting skip_router to true on Context

Alternate Designs

Benefits

It allows skipping router handlers from Grip pipelines.

Possible Drawbacks

@cyangle
Copy link
Contributor Author

cyangle commented Aug 21, 2024

@grkek Please review.

@grkek
Copy link
Member

grkek commented Sep 8, 2024

@cyangle You can remove HTTP and WebSocket routers from the main router array

@cyangle
Copy link
Contributor Author

cyangle commented Sep 10, 2024

@grkek This is to skip the router handlers dynamically per request.

@grkek
Copy link
Member

grkek commented Oct 22, 2024

I do not see a reason to include this in the framework.

@grkek grkek closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants