-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Graph Store Drivers #1006
Add Graph Store Drivers #1006
Conversation
…documentation, along with changed to CHANGELOG
@Kornspan from the read the docs build:
Seems to be a source of issues on the unit tests as well. |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Fix lint errors
fix make check
Hi can you comment what error occurred in the mkdocs? @collindutter @vachillo |
@galshubeli here's the output:
Note that you can run the build process yourself with |
@collindutter I encountered this error while running it on the dev and main branch as well. Do you know what the possible cause might be? |
@galshubeli Are your dependencies up to date? Can you try: make install/all
make docs I do get quite a few Separately, I want to apologize for the lack of attention our team has given to this PR. We're definitely interested in incorporating Graph Store Drivers into Griptape and have already started some initial work ourselves. However, we haven't yet fully figured out how they fit into the bigger picture. They will likely play a key role in Given this uncertainty, it's hard for us to provide meaningful feedback on the PR right now. For the time being, it might make sense to close the PR and revisit it once we've solidified our approach. When we're ready, we'd love to get your input on it! CC @Kornspan |
Hey all, I'm going to close this PR for the reasons mentioned above. Once we're ready to support Graph Drivers we'll reach back out! |
Describe your changes
Additional Context:
This implementation allows future integrations with other graph databases.
Changes Made:
pyproject.toml
.Issue ticket number and link
Closes #915
📚 Documentation preview 📚: https://griptape--1006.org.readthedocs.build//1006/