Update dependencies, fix emergent issues #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
chore/update-deps
branch
from
c5a6cf9 to
db70a59
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dylanholmes
reviewed
Aug 14, 2024
Comment on lines
-28
to
+29
| api_key: str = field(default=Factory(lambda: os.getenv("GT_CLOUD_API_KEY")), kw_only=True) | ||
| api_key: Optional[str] = field(default=Factory(lambda: os.getenv("GT_CLOUD_API_KEY")), kw_only=True) |
There was a problem hiding this comment.
Why should api_key be allowed to be None?
There was a problem hiding this comment.
Because os.getenv("GT_CLOUD_API_KEY") returns str | None. Should we instead change to os.environ?
| @pytest.fixture() | ||
| @pytest.fixture |
There was a problem hiding this comment.
Why reverting this change? Did we change formatting rules?
(looks like this is the biggest diff contributor in the pr)
There was a problem hiding this comment.
Ah I just realized that the original is the "correct" way. I had it backwards, will investigate and revert.
collindutter
force-pushed
the
chore/update-deps
branch
from
db70a59 to
0e716a2
Compare
vachillo
previously approved these changes
Aug 15, 2024
collindutter
force-pushed
the
chore/update-deps
branch
from
04c7e23 to
1b0aec3
Compare
vachillo
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update dependencies, fix emergent issues
Issue ticket number and link
NA