Use subtask output if no action output #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasinov
previously approved these changes
Aug 16, 2024
collindutter
force-pushed
the
hotfix/toolkit-output
branch
from
55dab28 to
63d3a38
Compare
vachillo
reviewed
Aug 16, 2024
griptape/tasks/toolkit_task.py
Outdated
| @@ -83,7 +83,7 @@ def prompt_stack(self) -> PromptStack: | |||
| for action in s.actions | |||
| ] | |||
| action_results = [ | |||
| ToolAction(name=action.name, path=action.path, tag=action.tag, output=action.output) | |||
| ToolAction(name=action.name, path=action.path, tag=action.tag, output=action.output or s.output) | |||
There was a problem hiding this comment.
None check?
Suggested change
| ToolAction(name=action.name, path=action.path, tag=action.tag, output=action.output or s.output) | |
| ToolAction(name=action.name, path=action.path, tag=action.tag, output=action.output if action.output is not None else s.output) |
collindutter
force-pushed
the
hotfix/toolkit-output
branch
from
63d3a38 to
5458397
Compare
vasinov
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If an
ActionsSubtaskcrashes before any of itsToolAction's have an output, that output should be used as theToolActionoutput when buildingActionArtifacts.This fixes
An assistant message with 'tool_calls' must be followed by tool messages responding to each 'tool_call_id'. The following tool_call_ids did not have response messages.Issue ticket number and link
Offline discussion.