Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/naming #1078

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Refactor/naming #1078

merged 3 commits into from
Aug 19, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Aug 19, 2024

Describe your changes

  • Rename config.drivers to config.driver_config.
  • Rename config.logging to config.logging_config.
  • Add _driver suffix to all fields in DriverConfig.

Issue ticket number and link

Offline discussion.


📚 Documentation preview 📚: https://griptape--1078.org.readthedocs.build//1078/

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
griptape/utils/chat.py 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter marked this pull request as ready for review August 19, 2024 19:12
@collindutter collindutter merged commit f08f0c3 into dev Aug 19, 2024
13 checks passed
@collindutter collindutter deleted the refactor/naming branch August 19, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants