Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing maxTokens in AmazonBedrockPromptDriver #1123

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

collindutter
Copy link
Member

Describe your changes

Fixed

  • Missing maxTokens inference parameter in AmazonBedrockPromptDriver.

Issue ticket number and link

Closes #1120

@collindutter collindutter requested a review from shhlife August 29, 2024 22:36
@collindutter collindutter force-pushed the fix/bedrock-max-tokens branch from c9c7a1d to 5479d77 Compare August 29, 2024 22:47
shhlife
shhlife previously approved these changes Aug 29, 2024
Copy link

@shhlife shhlife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works beautifully, thank you!

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@collindutter collindutter requested a review from shhlife August 29, 2024 23:20
Copy link

@shhlife shhlife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! :)

@collindutter collindutter merged commit ab25735 into dev Aug 29, 2024
13 checks passed
@collindutter collindutter deleted the fix/bedrock-max-tokens branch August 29, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_tokens not working with AmazonBedrockPromptDriver
2 participants