Drivers Config Context Manager #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
feature/driver-config-context
branch
4 times, most recently
from
6442f96 to
ad0c28b
Compare
1 task
vachillo
reviewed
Sep 9, 2024
Comment on lines
62
to
69
| def __exit__(self, type, value, traceback) -> None: # noqa: ANN001, A002 | ||
| from griptape.configs import Defaults | ||
|
|
||
| Defaults.drivers_config = self._old_drivers_config | ||
|
|
There was a problem hiding this comment.
probably should add self._old_drivers_config = None
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
collindutter
commented
Sep 9, 2024
There was a problem hiding this comment.
@zachgiordano I think this example may be doing too much for what we're trying to illustrate.
What do you think about instead beefing up the existing custom example? @vachillo what do you think?
collindutter
force-pushed
the
feature/driver-config-context
branch
2 times, most recently
from
a25bd38 to
aaf4528
Compare
vachillo
previously approved these changes
Sep 9, 2024
dylanholmes
previously approved these changes
Sep 11, 2024
collindutter
dismissed stale reviews from vachillo and dylanholmes
via
64e0342
collindutter
force-pushed
the
feature/driver-config-context
branch
from
94453c7 to
64e0342
Compare
…y setting the default Drivers.
collindutter
force-pushed
the
feature/driver-config-context
branch
from
64e0342 to
99e3b99
Compare
dylanholmes
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added ability to use Drivers Configs as Context Managers for temporarily setting the default Drivers.
Issue ticket number and link
NA
📚 Documentation preview 📚: https://griptape--1162.org.readthedocs.build//1162/