Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ToolkitTask, add functionality to PromptTask #1463

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Dec 19, 2024

Describe your changes

Deprecated

  • ToolkitTask. PromptTask is a drop-in replacement.

Issue ticket number and link

Closes #1464

@collindutter collindutter force-pushed the refactor/prompt-tasks branch 2 times, most recently from f7329ec to 778be51 Compare December 19, 2024 00:52
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 93.27731% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
griptape/tasks/prompt_task.py 92.45% 3 Missing and 5 partials ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter added the type:enhancement Improvements to existing features label Dec 19, 2024
Copy link
Contributor

@dylanholmes dylanholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈

@collindutter collindutter marked this pull request as ready for review December 20, 2024 19:31
@collindutter collindutter force-pushed the refactor/prompt-tasks branch 2 times, most recently from 229d290 to 11969e0 Compare December 20, 2024 19:43
@collindutter collindutter merged commit 23ac354 into main Dec 20, 2024
16 checks passed
@collindutter collindutter deleted the refactor/prompt-tasks branch December 20, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge PromptTask, ToolkitTask, and ToolTask
2 participants