Update DuckDuckGoWebSearchDriver #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
chore/duckduckgo
branch
2 times, most recently
from
bbbe1ea to
291f2b1
Compare
dylanholmes
approved these changes
Dec 20, 2024
| "docs/griptape-framework/data/src/loaders_10.py", | ||
| "docs/griptape-framework/drivers/src/web_search_drivers_3.py", |
There was a problem hiding this comment.
Were these missing from the integration tests? Do we not have an automatic way of detecting them? (Like docs/**/*.py or something?)
There was a problem hiding this comment.
These particular tests are skipped because they rely on resources that are not trivial to set up (or are non-functional in the case of DDG)
collindutter
force-pushed
the
chore/duckduckgo
branch
3 times, most recently
from
66db291 to
cf33154
Compare
|
It's already fine, update to the latest version |
collindutter
force-pushed
the
chore/duckduckgo
branch
from
cf33154 to
2ffbf02
Compare
|
@deedy5 that's great to hear, just confirmed it's working again 🎉. Thanks for the awesome package, and happy to see it's unarchived! |
collindutter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
### Deprecated-DuckDuckGoWebSearchDriver.DuckDuckGoWebSearchDriverrelies onduckduckgo_searchwhich is no longer maintained and has been archived.duckduckgo_searchhas been unarchived and updated.Issue ticket number and link
Closes #1473
📚 Documentation preview 📚: https://griptape--1474.org.readthedocs.build//1474/