Fix/futures context #1512
Merged
Fix/futures context #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
fix/futures-context
branch
2 times, most recently
from
0df9525 to
b72086b
Compare
collindutter
force-pushed
the
fix/futures-context
branch
from
b72086b to
5c77ab5
Compare
vachillo
reviewed
Jan 7, 2025
|
|
||
| def __raise_deprecation_warning(self) -> None: | ||
| warnings.warn( | ||
| "`FuturesExecutorMixin.futures_executor` is deprecated and will be removed in a future release. Use `FuturesExecutorMixin.create_futures_executor` instead.", |
There was a problem hiding this comment.
maybe specify "use FuturesExecutorMixin.create_futures_executor() as a context manager instead."? better to be explicit
There was a problem hiding this comment.
Technically you could use it not as a context manager:
executor = self.create_futures_executor()
executor.shutdown()
Comment on lines
-21
to
-29
| def __del__(self) -> None: | ||
| executor = self.futures_executor | ||
|
|
||
| if executor is not None: | ||
| self.futures_executor = None # pyright: ignore[reportAttributeAccessIssue] In practice this is safe, nobody will access this attribute after this point | ||
|
|
||
| with contextlib.suppress(Exception): | ||
| # don't raise exceptions in __del__ | ||
| executor.shutdown(wait=True) |
There was a problem hiding this comment.
is this currently safe to remove without causing the issues that caused it to be added?
There was a problem hiding this comment.
I believe that was resolved by #1074. This particular method was only introduced as a clean-up effort.
vachillo
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed
FuturesExecutorMixincleanup.Deprecated
FuturesExecutorMixin.futures_executor. UseFuturesExecutorMixin.create_futures_executorinstead.Issue ticket number and link
Closes #1507