Add back all_rulesets in favor of rulesets property cleverness #1536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
RuleMixin._rulesets
is marked as serializable, but it has an alias,rulesets
. When serializingRuleMixin
the property ,rulesets
, gets serialized rather than the field.This leads to some unintended behavior where the serialized
rulesets
field contains the "Default Ruleset" added by theruleset
property.Solution:
Remove the cleverness of having
rulesets
be both a field and property by re-introducingall_rulesets
.all_rulesets
is only used at runtime and is not serialized.Issue ticket number and link
Closes #1465