Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated HuggingFacePipelinePromptDriver to use chat features of transformers.TextGenerationPipeline. #832

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Updated HuggingFacePipelinePromptDriver to use chat features of transformers.TextGenerationPipeline. #832

merged 2 commits into from
Jun 5, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Jun 5, 2024 •
edited
Loading

📚 Documentation preview 📚: https://griptape--832.org.readthedocs.build//832/

@collindutter collindutter requested review from dylanholmes and a team June 5, 2024 00:25
@collindutter collindutter changed the title Updated HuggingFacePipelinePromptDriver to use chat features of `tr… Updated HuggingFacePipelinePromptDriver to use chat features of transformers.TextGenerationPipeline. Jun 5, 2024
@collindutter collindutter force-pushed the refactor/huggingface-pipe branch from d065b16 to 602530a Compare June 5, 2024 01:03
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Files Patch % Lines
...ivers/prompt/huggingface_pipeline_prompt_driver.py 83.33% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter force-pushed the refactor/huggingface-pipe branch from 602530a to f8c4764 Compare June 5, 2024 01:11
dylanholmes
dylanholmes previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@dylanholmes dylanholmes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nicely simplified prompt driver example!

Just minor comments/questions that I'll leave to your discretion.

griptape/drivers/prompt/huggingface_pipeline_prompt_driver.py Show resolved Hide resolved
griptape/drivers/prompt/huggingface_pipeline_prompt_driver.py Outdated Show resolved Hide resolved
@collindutter collindutter force-pushed the refactor/huggingface-pipe branch from f8c4764 to 7a048d3 Compare June 5, 2024 15:38
@collindutter collindutter requested a review from dylanholmes June 5, 2024 15:38
@collindutter collindutter merged commit 7025db8 into dev Jun 5, 2024
12 checks passed
@collindutter collindutter deleted the refactor/huggingface-pipe branch June 5, 2024 16:45
@collindutter collindutter mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanholmes dylanholmes dylanholmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@collindutter @dylanholmes