Feature/native functions #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
changed the base branch from
dev
to
refactor/prompt-stack-elements2
collindutter
force-pushed
the
feature/native-functions
branch
from
abc66b1 to
1c8648b
Compare
collindutter
force-pushed
the
feature/native-functions
branch
from
1c8648b to
ab214a9
Compare
collindutter
force-pushed
the
refactor/prompt-stack-elements2
branch
3 times, most recently
from
b110a4f to
f756096
Compare
collindutter
force-pushed
the
feature/native-functions
branch
from
ab214a9 to
4dd3e4b
Compare
collindutter
force-pushed
the
refactor/prompt-stack-elements2
branch
from
19337e1 to
7abc1cc
Compare
collindutter
force-pushed
the
feature/native-functions
branch
from
4dd3e4b to
6d66095
Compare
collindutter
force-pushed
the
refactor/prompt-stack-elements2
branch
from
7abc1cc to
ab2a2dd
Compare
collindutter
force-pushed
the
feature/native-functions
branch
from
db726c7 to
a78c8f2
Compare
collindutter
force-pushed
the
refactor/prompt-stack-elements2
branch
from
ffd1dd9 to
04f2ed9
Compare
collindutter
force-pushed
the
feature/native-functions
branch
from
06a5190 to
fc53df6
Compare
collindutter
force-pushed
the
refactor/prompt-stack-elements2
branch
from
04f2ed9 to
e6e63b9
Compare
collindutter
force-pushed
the
feature/native-functions
branch
2 times, most recently
from
6bb026e to
09bcd0c
Compare
collindutter
force-pushed
the
refactor/prompt-stack-elements2
branch
from
1767a83 to
a53762d
Compare
collindutter
force-pushed
the
feature/native-functions
branch
2 times, most recently
from
c0540fb to
d8c42ef
Compare
dylanholmes
previously approved these changes
Jul 9, 2024
CHANGELOG.md
Outdated
| @@ -55,6 +55,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Support for `PromptTask`s to take `TextArtifact`s, `ImageArtifact`s, and `ListArtifact`s as input. | |||
| - Parameters `sort_key` and `sort_key_value` on `AmazonDynamoDbConversationMemoryDriver` for tables with sort keys. | |||
| - `Reference` for supporting artifact citations in loaders and RAG engine modules. | |||
| - Native function calling support to `OpenAiChatPromptDriver`, `AzureOpenAiChatPromptDriver`, `AnthropicPromptDriver`, `AmazonBedrockPromptDriver`, `GooglePromptDriver`, and `CoherePromptDriver`. | |||
collindutter
force-pushed
the
feature/native-functions
branch
from
a288e2a to
ba8e2f6
Compare
dylanholmes
previously approved these changes
Jul 9, 2024
vasinov
requested changes
Jul 10, 2024
Comment on lines
17
to
24
| Attributes: | ||
| tag: The tag (unique identifier) of the action. | ||
| name: The name (Tool name) of the action. | ||
| path: The path (Tool activity name) of the action. | ||
| input: The input (Tool params) of the action. | ||
| tool: The matched Tool of the action. | ||
| output: The output (Tool result) of the action. | ||
| """ |
There was a problem hiding this comment.
This docstring should be in Action.
griptape/common/action.py
Outdated
|
|
||
|
|
||
| @define(kw_only=True) | ||
| class Action(SerializableMixin): |
There was a problem hiding this comment.
Should we add some prefix to this? I'm worried that we might have some other "action" in the future, unrelated to LLM actions, which will be confusing naming-wise.
There was a problem hiding this comment.
Refactored into BaseAction and ToolAction
griptape/common/action.py
Outdated
| def __str__(self) -> str: | ||
| return json.dumps(self.to_dict()) | ||
|
|
||
| def to_dict(self) -> dict: |
There was a problem hiding this comment.
Why did you need to override this? Can't we just set tool and output to non-serializable?
collindutter
force-pushed
the
feature/native-functions
branch
from
cb45f54 to
a06442c
Compare
collindutter
force-pushed
the
feature/native-functions
branch
from
a06442c to
9c44a62
Compare
collindutter
force-pushed
the
feature/native-functions
branch
from
a24a39a to
3d4fd4a
Compare
vasinov
requested changes
Jul 10, 2024
griptape/common/prompt_stack/contents/action_call_delta_message_content.py
Show resolved
Hide resolved
vasinov
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://griptape--867.org.readthedocs.build//867/
Closes #91